fix: add Redis setup instructions and handle missing Redis connection gracefully#773
Closed
rashmivemuri wants to merge 12 commits intoOWASP:mainfrom
Closed
fix: add Redis setup instructions and handle missing Redis connection gracefully#773rashmivemuri wants to merge 12 commits intoOWASP:mainfrom
rashmivemuri wants to merge 12 commits intoOWASP:mainfrom
Conversation
…ce fixed width: 16rem with width: 100%; max-width: 16rem - Input now shrinks gracefully on small screens (320px-375px) - Desktop appearance preserved via max-width cap - Fix duplicate background-color declaration - Fix invalid // comment syntax in .search-error rule Part of OWASP#691 Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
…height value (removed stray word "consideration") - Fix invalid // comment syntax in .chat-input and .chat-surface Part of OWASP#691 Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
Added styles to fix navbar logo overflow and adjust mobile padding and margins. Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
…P#691) Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
Added responsive styles for mobile view. Problem: - .cre-page had no mobile media queries at all - padding: 30px with no mobile override causes content to touch screen edges on small devices - width: 50% on __description creates a ~187px wide text column on 375px screens, making content very cramped - font sizes (2rem heading, 1.2rem sub-heading) are oversized for mobile viewports Fix: - Added @media (max-width: 768px) block at bottom of file - Reduced padding to 1rem on mobile - Expanded __description width to 100% on mobile - Reduced __heading font-size from 2rem to 1.5rem - Reduced __sub-heading font-size from 1.2rem to 1rem Desktop layout is completely untouched. Only fires on screens 768px and below. Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
…Part of OWASP#691) Adjusted styles for mobile responsiveness, including padding and width changes for search field and item margins. Problem: - main#explorer-content had padding: 30px with no mobile override - search input fixed at 320px overflows on screens < 375px - .item had margin-left: 40px causing content overflow on mobile Fix: - Added @media (max-width: 768px) block at bottom of file - Reduced padding to 1rem on mobile - Expanded search input width to 100% on mobile - Reduced .item left margin to 1rem on mobile Desktop layout completely untouched. Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
Problem: - .standard-page had padding: 30px with no mobile override - font sizes (2rem heading, 1.2rem sub-heading) are oversized for mobile viewports - existing media query only handled word-break, not padding or font sizes Fix: - Added @media (max-width: 768px) block at bottom of file - Reduced padding to 1rem on mobile - Reduced __heading font-size from 2rem to 1.5rem - Reduced __sub-heading font-size from 1.2rem to 1rem Desktop layout completely untouched. Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
Adjusted padding for gap analysis on smaller screens. Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
Added instructions for starting required services before running the application. Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
Added error handling for Redis connection failure. Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #652
Problem
When running OpenCRE locally, the map analysis feature fails with a Redis
connection error because the setup documentation does not mention starting
Redis before running the app.
Changes
docs/developmentSetup.md - Added
make start-containersstep in theRunning Locally section so users know to start Redis and Neo4j first.
application/utils/gap_analysis.py - Added a None check after
redis.connect() so if Redis is unavailable, the app returns a clear
error message instead of crashing.