chromium: don't pass is_official_build=true when doing a component-build#603
chromium: don't pass is_official_build=true when doing a component-build#603Villemoes wants to merge 1 commit intoOSSystems:masterfrom
Conversation
When setting the PACKAGECONFIG component-build, the build breaks
immediately due to this from the toplevel BUILD.gn:
if (is_official_build) {
# An official (maximally optimized!) component (optimized for build times)
# build doesn't make sense and usually doesn't work.
assert(!is_component_build)
}
So we must make is_official_build the negative of component-build.
|
Ping. Is there any other way to get the component-build packageconfig working? It is officially listed in the README.md, but does it actually currently work for anybody? |
|
The patch looks valid to me, but it does seem to indicate that nobody has tested the component build knob in ages. Do you get a working binary if you build the recipe with this patch? |
|
Unfortunately, no, I don't even get a binary. The build fails towards the end with an error I can't decipher: But that symbol does exist in |
When setting the PACKAGECONFIG component-build, the build breaks
immediately due to this from the toplevel BUILD.gn:
So we must make is_official_build the negative of component-build.