OS-244 #246 Adding Datafordeler address lookup#327
Conversation
jekuaitk
left a comment
jekuaitk
left a comment
There was a problem hiding this comment.
Should we bump os2web/os2web_datalookup version when it is merged to ensure an up-to-date version?
| '#pattern' => '^(\d{3},?)*$', | ||
| '#description' => $this->t('CSV list of municipalities codes, what will limit the address lookup.'), | ||
| '#title' => $this->t('Limit by municipality'), | ||
| '#pattern' => '^(\d{4})$', |
There was a problem hiding this comment.
So only single municipality limits now? Also, would this not silently break existing webforms?
There was a problem hiding this comment.
in the worst case, that would produce empty result (if there has been a multivalue value before).
We haven't talked about any migration logic, i also don't see any good migration logic here. I would say that is a manual process after migration, @ds-bellcom what is your say on this?
There was a problem hiding this comment.
I don't see any clear migration logic either. If this limitation is indeed intended we need to ensure webform builders are made aware of it! Let's see what @ds-bellcom has to say :-)
There was a problem hiding this comment.
@stankut @jekuaitk As I understand the new API from Klimadatastyrelsen, multiple municipality codes are not supported - see here: https://confluence.sdfi.dk/pages/viewpage.action?pageId=244318431
Regardless of whether you use "Husnummersøgning" or "Adressesøgning", the "kommunekode" must only be 4 digits - no more, no less.
I don't see any good migration solution - other than that the forms where the DAWA elements are used are reviewed. This is of course something that needs to be communicated to the users so that they can do this review.
jekuaitk
left a comment
jekuaitk
left a comment
There was a problem hiding this comment.
Looks good! Awaiting clarification on the municipality limitation.
3 participants
No description provided.