Distinction of Magnetization vs. Line Shunt (Validation) - #486
Open
lukelowry wants to merge 1 commit into
Open
Conversation
lukelowry
force-pushed
the
lukel/mag-shunt-dev
branch
5 times, most recently
from
July 17, 2026 21:58
09038e0 to
797cc53
Compare
lukelowry
marked this pull request as ready for review
July 22, 2026 06:16
Collaborator
Author
|
An updated circuit diagram is outside the scope of this PR, so marking ready. The proposed changes also help future proof our |
lukelowry
force-pushed
the
lukel/mag-shunt-dev
branch
2 times, most recently
from
July 22, 2026 14:59
d855d2d to
b700206
Compare
lukelowry
force-pushed
the
lukel/mag-shunt-dev
branch
from
July 24, 2026 23:18
b700206 to
2ad4034
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation on
developtreats the shunt as a magnetizing admittance, which should have a distinct parameter from the line shunt admittance, which does not observe the effects of phase/tap changes.Before these changes, the Branch model is presumed to be either a XFMR or a line but not a line & XFMR in series. We need to support this edge case
MATPOWER does not seem to make this distinction, but PowerWorld models this correctly. This contributed marginally to errors in magnetization admittances in some cases.
Required before
0.2release.Proposed changes
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Need to update the circuit mdoel diagram in future