Skip to content

Distinction of Magnetization vs. Line Shunt (Validation) - #486

Open
lukelowry wants to merge 1 commit into
developfrom
lukel/mag-shunt-dev
Open

Distinction of Magnetization vs. Line Shunt (Validation)#486
lukelowry wants to merge 1 commit into
developfrom
lukel/mag-shunt-dev

Conversation

@lukelowry

@lukelowry lukelowry commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Implementation on develop treats the shunt as a magnetizing admittance, which should have a distinct parameter from the line shunt admittance, which does not observe the effects of phase/tap changes.

Before these changes, the Branch model is presumed to be either a XFMR or a line but not a line & XFMR in series. We need to support this edge case

MATPOWER does not seem to make this distinction, but PowerWorld models this correctly. This contributed marginally to errors in magnetization admittances in some cases.

Required before 0.2 release.

Proposed changes

  • Add magnetic charging admittance term
  • Move G and B contribution outside of tap/phase transformation

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • NA I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

Need to update the circuit mdoel diagram in future

@lukelowry
lukelowry requested a review from abirchfield July 10, 2026 23:46
@lukelowry
lukelowry force-pushed the lukel/mag-shunt-dev branch 5 times, most recently from 09038e0 to 797cc53 Compare July 17, 2026 21:58
@lukelowry
lukelowry marked this pull request as ready for review July 22, 2026 06:16
@lukelowry

Copy link
Copy Markdown
Collaborator Author

An updated circuit diagram is outside the scope of this PR, so marking ready. The proposed changes also help future proof our Branch model so it can be used for XFMR, line, and composite XFMR-line model.

@lukelowry
lukelowry force-pushed the lukel/mag-shunt-dev branch 2 times, most recently from d855d2d to b700206 Compare July 22, 2026 14:59
@lukelowry
lukelowry force-pushed the lukel/mag-shunt-dev branch from b700206 to 2ad4034 Compare July 24, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant