Use ports for PhasorDynamics signal connectivity#440
Draft
lukelowry wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates PhasorDynamics component wiring so signal nodes are associated with input/output ports instead of internal/external variable enums.
Closes #407
@PhilipFackler, what are your thoughts? Managed to do it with no
*.case.jsonchanges, which lets us do the INPUT_FORMAT changes and documentation with a few changes in code once we get to itProposed changes
"ports"format, but parse entries into the new internal maps.ComponentSignals,SystemModel, components, examples, and tests to use port enums for signal wiring.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
I organized the commits so we can roll back if the scope is too big, but it was mechanical and straightforward after the main changes were in.