Separate compilation units and targets for SystemModel#437
Open
PhilipFackler wants to merge 1 commit into
Open
Separate compilation units and targets for SystemModel#437PhilipFackler wants to merge 1 commit into
SystemModel#437PhilipFackler wants to merge 1 commit into
Conversation
57e510c to
53f2082
Compare
nkoukpaizan
approved these changes
Jun 6, 2026
Collaborator
nkoukpaizan
left a comment
There was a problem hiding this comment.
Thanks for getting this out of the way!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
SystemModelimplementation to dedicated compilation unit(s).Closes #408
Proposed changes
Move implementation code for
SystemModeltoSystemModelImpl.hppand declares class template instantiations inSystemModel.cppandSystemModelDependencyTracking.cpp.Checklist
-Wall -Wpedantic -Wconversion -Wextra.