Skip to content

Separate compilation units and targets for SystemModel#437

Open
PhilipFackler wants to merge 1 commit into
developfrom
PhilipFackler/systemmodel-cpp
Open

Separate compilation units and targets for SystemModel#437
PhilipFackler wants to merge 1 commit into
developfrom
PhilipFackler/systemmodel-cpp

Conversation

@PhilipFackler
Copy link
Copy Markdown
Collaborator

Description

Move SystemModel implementation to dedicated compilation unit(s).

Closes #408

Proposed changes

Move implementation code for SystemModel to SystemModelImpl.hpp and declares class template instantiations in SystemModel.cpp and SystemModelDependencyTracking.cpp.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A] I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@PhilipFackler PhilipFackler force-pushed the PhilipFackler/systemmodel-cpp branch from 57e510c to 53f2082 Compare June 5, 2026 21:11
@nkoukpaizan nkoukpaizan added enhancement New feature or request cleanup labels Jun 6, 2026
Copy link
Copy Markdown
Collaborator

@nkoukpaizan nkoukpaizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this out of the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make distinct compilation unit(s) for SystemModel

2 participants