PD-5947 Move the record corrections page to the Angular app - #2908
Open
cryptalith wants to merge 1 commit into
Open
PD-5947 Move the record corrections page to the Angular app#2908cryptalith wants to merge 1 commit into
cryptalith wants to merge 1 commit into
Conversation
Serve /record-corrections from orcid-angular instead of the legacy FreeMarker page, following the Figma design. The page keeps using the existing public /record-corrections/next and /previous endpoints, which paginate by row id rather than by page number. The pre-migration /about/trust/integrity/record-corrections URL redirects to the new route. TitleService matches on the requested URL rather than the redirected one, so that path carries its own label. The loading state uses the shared skeleton placeholder from @orcid/ui, laid out in the table's own columns so it resolves into the loaded rows without the layout shifting.
Member
|
Task linked: PD-5947 Update record corrections page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/record-correctionsfrom a new lazy-loaded feature module instead of the legacy FreeMarker/ng2 page, matching the Figma design./record-corrections/nextand/previousendpoints as-is (keyset pagination by row id, page size 10, no backend contract change)./about/trust/integrity/record-correctionsredirects to the new route and carries its own title label, sinceTitleServicematches the requested URL rather than the redirected one.SkeletonPlaceholderComponentfrom@orcid/ui, laid out in the table's own columns.Pairs with ORCID/ORCID-Source#lmendoa/PD-5947, which flips nginx routing to this page and removes the legacy view. This Angular PR is safe to deploy first — nginx still routes the path to the legacy app until that PR lands.