fix: copy projects/ directory into Docker builds - #2905
Open
gilesw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker build (
docker-compose.build.yml) was failing becauseDockerfile.build(andDockerfile.build.yarn) never copied theprojects/directory into the build container. The@orcid/ui,@orcid/registry-ui, and@orcid/tokenslibraries live underprojects/and are resolved via path mappings intsconfig.json, so the Angular compiler couldn't find them:GitHub CI was unaffected because it checks out the full repo and builds directly on the filesystem — no Docker layer involved.
Fix
Added
COPY ./projects ./projectsto both Dockerfiles so the library source is available at build time:Dockerfile.build— added afterCOPY ./src ./src, before themvn packagestepDockerfile.build.yarn— added afterCOPY scripts/ scripts/, beforeRUN yarn build