Skip to content

HYRAX-1964: Add job to build docker image for el9#1238

Merged
hannahilea merged 28 commits intomasterfrom
hr/rhel9-docker
Mar 5, 2026
Merged

HYRAX-1964: Add job to build docker image for el9#1238
hannahilea merged 28 commits intomasterfrom
hr/rhel9-docker

Conversation

@hannahilea
Copy link
Copy Markdown
Contributor

Description

As noted in #1213, added travis job that is identical to the job to build a rocky8 image, but updated the env variables for rocky9.

Tasks

  • Ticket exists and is linked in title
  • Tests added/updated
  • Dead code removed
  • No TODOs added

@hannahilea
Copy link
Copy Markdown
Contributor Author

Looks like failure is due to a couple failing tests---not sure what about those would be rocky9-specific?

@hannahilea
Copy link
Copy Markdown
Contributor Author

Okay, so it looks like this is a "rocky9" issue and not a "docker image of rocky9" issue, so I'm not going to spend time attempting to diagnose/fix the failing tests right now. (As far as I know, we don't pass tests elsewhere, so this isn't a newly introduced failure.)

I've filed the ticket as https://github.com/OPENDAP/internal-projects/issues/15 and we can handle it as part of the "update RHEL version" project.

@hannahilea hannahilea changed the title HYRAX-1964: Add job to build docker image for rocky9 too HYRAX-1964: Add job to build docker image for el9 Feb 25, 2026
@hannahilea
Copy link
Copy Markdown
Contributor Author

Two tests initially failed when run on el9: modules/ncml_module/tests/testsuite 399 and 400.

I built them "locally" (in docker) and looked at the logs; it seems like it's because when the test greps for the error string, grep responds with "binary file matches"---i.e., there's a match BUT that match won't be printed out, because the file seems to be binary (perhaps due to a null character or something), and that is not picked up as passing the test. I'm adding a grep --text flag to the test, which will hopefully return us to the expected behavior.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 4, 2026

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 4, 2026

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

@ndp-opendap ndp-opendap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions...

AT_MAKE_BESCMD_FILE([$1], [$2], [$4])
AT_CHECK([besstandalone -c bes_conf_path -i ./test.bescmd], [$5], [stdout], [ignore])
AT_CHECK([grep $3 stdout], [], [ignore], [], [])
AT_CHECK([grep --text $3 stdout], [], [ignore], [], [])
Copy link
Copy Markdown
Contributor

@ndp-opendap ndp-opendap Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disturbs me. I get that it works, but is there any difference between the baselines and what's happening on el9?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't compare against baselines---we check that the expected string ($3) shows up in the response. No other tests throw issues (e.g., none of the baseline diffs), so I assume those continue to be identical.

Comment thread Dockerfile
ARG BUILDER_BASE_IMAGE
ARG FINAL_BASE_IMAGE
FROM ${BUILDER_BASE_IMAGE} AS builder
FROM ${BUILDER_BASE_IMAGE:-"rockylinux:8"} AS builder
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a single Docker file for both el8 and el9 builds?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This addition is purely to keep docker from warning about lack of default image... we then do the same dance as we do on hyrax-docker, namely, we immediately test for the presence of the variable and fail if it wasn't found)

@hannahilea hannahilea merged commit 887c1a4 into master Mar 5, 2026
7 of 8 checks passed
@hannahilea hannahilea deleted the hr/rhel9-docker branch March 5, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants