TEDEFO-1854 Align toolkit to improved uniqueness testing#131
Merged
bertrand-lorentz merged 2 commits intodevelopfrom Feb 9, 2026
Merged
TEDEFO-1854 Align toolkit to improved uniqueness testing#131bertrand-lorentz merged 2 commits intodevelopfrom
bertrand-lorentz merged 2 commits intodevelopfrom
Conversation
Contributor
rousso
commented
Feb 4, 2026
rousso
commented
- Implement typed uniqueness conditions (any value in any collection)
- Fix: repeatable fields used as own context treated as scalar
- Rename error code EXPECTED_SEQUENCE to EXPECTED_SCALAR
- Implement typed uniqueness conditions (any value in any collection) - Fix: repeatable fields used as own context treated as scalar - Rename error code EXPECTED_SEQUENCE to EXPECTED_SCALAR
bertrand-lorentz
requested changes
Feb 6, 2026
| void testUniqueValueCondition() { | ||
| testExpressionTranslationWithContext( | ||
| "count(for $x in PathNode/TextField, $y in /*/PathNode/TextField[. = $x] return $y) = 1", | ||
| "count(/*/PathNode/TextField/normalize-space(text())[. = PathNode/TextField/normalize-space(text())]) = 1", |
Contributor
There was a problem hiding this comment.
This is not a valid XPath expression: /*/PathNode/TextField/normalize-space(text()) is not a node, it is a list of strings, so it cannot be used with a predicate.
In addition, the content of the predicate does not do what we need: the right hand-side of . = PathNode/TextField/normalize-space(text()) looks for a PathNode under the current TextField.
Contributor
Author
There was a problem hiding this comment.
Good catch. The typed uniqueness conditions now use a for loop to bind the needle value before filtering the haystack:
count(for $n in needle, $x in haystack[. = $n] return $x) = 1
This avoids both issues:
- The predicate
[. = $n]compares two atomic values (no path navigation from a string context) - The needle is evaluated in the outer context, so relative paths resolve correctly
Fixed in a06cc97.
bertrand-lorentz
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.