Skip to content

[16.0] web_group_expand: show buttons in account ListView#3463

Open
robperezit wants to merge 1 commit intoOCA:16.0from
robperezit:16.0-dev-fix-web_group_expand_visibility
Open

[16.0] web_group_expand: show buttons in account ListView#3463
robperezit wants to merge 1 commit intoOCA:16.0from
robperezit:16.0-dev-fix-web_group_expand_visibility

Conversation

@robperezit
Copy link

The account module defines a primary ListView buttons template (account.ListView.Buttons) used in invoices/bills lists (e.g. to add the Upload button). Since web_group_expand only extended web.ListView.Buttons, its expand/collapse buttons were not rendered in those views.

Extend account.ListView.Buttons too, injecting the buttons in o_list_buttons when the list is grouped.

#3123

The account module defines a primary ListView buttons template
(account.ListView.Buttons) used in invoices/bills lists (e.g. to add the
Upload button). Since web_group_expand only extended web.ListView.Buttons,
its expand/collapse buttons were not rendered in those views.

Extend account.ListView.Buttons too, injecting the buttons in o_list_buttons
when the list is grouped.
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would require a dependency on the account module?

I think a new module account_group_expand would be best.

@robperezit
Copy link
Author

Thanks for the review! @CRogos

To align with OCA conventions: would you prefer

  1. adding a small glue addon in this repository/branch (e.g. web_group_expand_account)
    depending on web_group_expand + account, containing only the
    account.ListView.Buttons template extension, or
  2. keeping this repository strictly generic and moving the account-specific part
    to another repo/addon instead?

I can adapt the PR accordingly (split into two PRs if needed).

@CRogos
Copy link
Contributor

CRogos commented Mar 3, 2026

You are asking the right questions... I don't know.
https://oca.github.io/repo-maintainer-conf/teams.html#web-maintainers

@simahawk @gurneyalex ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants