[18.0] [FIX] web_timeline: Migrate check_access_rights to has_access following deprecation#3462
Open
paradoxxxzero wants to merge 1 commit intoOCA:18.0from
Open
[18.0] [FIX] web_timeline: Migrate check_access_rights to has_access following deprecation#3462paradoxxxzero wants to merge 1 commit intoOCA:18.0from
paradoxxxzero wants to merge 1 commit intoOCA:18.0from
Conversation
alexey-pelykh
approved these changes
Mar 3, 2026
Contributor
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for this fix, Florian.
Verified that check_access_rights is indeed deprecated since Odoo 18.0 (emits DeprecationWarning) and that has_access is the correct boolean replacement.
The call signature change from check_access_rights([operation, false]) to has_access([[], operation]) correctly matches the new API — empty recordset + operation string. All three call sites (write, unlink, create) are consistently updated, and the test mock follows.
CI is green, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_access_rightsis deprecated in 18.0, replace it withhas_access