Skip to content

[18.0][REF] web_company_color: Update fetching scss_template#3426

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
PyTech-SRL:18.0-ref-web_company_color-override
Feb 6, 2026
Merged

[18.0][REF] web_company_color: Update fetching scss_template#3426
OCA-git-bot merged 1 commit intoOCA:18.0from
PyTech-SRL:18.0-ref-web_company_color-override

Conversation

@SirPyTech
Copy link
Copy Markdown
Contributor

Using a function to fetch SCSS_TEMPLATE to allow easier override from other modules.

Cherry-picked from #3185.

   Using a function to fetch SCSS_TEMPLATE
Copy link
Copy Markdown
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review LGTM

@SirPyTech
Copy link
Copy Markdown
Contributor Author

Thanks @flotho and @leemannd for having a look!

@flotho please click on "Approve" if these changes look good to you, so the review counts as an approval in Github Reviewers summary image

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Copy Markdown

@quirino95 quirino95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review LGTM

@pedrobaeza pedrobaeza added this to the 18.0 milestone Feb 6, 2026
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@pedrobaeza pedrobaeza changed the title [REF] web_company_color: Update fetching scss_template [18.0][REF] web_company_color: Update fetching scss_template Feb 6, 2026
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3426-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d157687 into OCA:18.0 Feb 6, 2026
9 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at b926a05. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants