[16.0][FIX] web_group_by_percentage: Added exclusion of non-field columns#3397
Conversation
fcayre
left a comment
fcayre
left a comment
There was a problem hiding this comment.
Code review + functional test OK
fcayre
force-pushed
the
16.0-fix-web_group_by_percentage-exclude_non_field_columns
branch
from
9bb05ad to
f95be60
Compare
|
This PR has the |
|
Sorry @Honeyxilia you are not allowed to rebase. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
Honeyxilia
force-pushed
the
16.0-fix-web_group_by_percentage-exclude_non_field_columns
branch
from
f95be60 to
5fa6b7c
Compare
In some list/tree views, there are non-field columns, for instance buttons to handle an action on a group of lines. Consequently, with this module installed, it's impossible to group lines in certain views, if the grouped view has a button, as using isNumericColumn, which tries to access the column in the view's fields, throws an Exception. As such, we exclude non-field columns from the computation of grouped columns percentages.
Honeyxilia
force-pushed
the
16.0-fix-web_group_by_percentage-exclude_non_field_columns
branch
from
5fa6b7c to
d2b3dc4
Compare
|
Makes sense, tests error is not related to this PR /ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 778a4af. Thanks a lot for contributing to OCA. ❤️ |
6 participants
In some list/tree views, there are non-field columns, for instance buttons to handle an action on a group of lines. Consequently, with this module installed, it's impossible to group lines in certain views, if the grouped view has a button, as using isNumericColumn, which tries to access the column in the view's fields, throws an Exception.
As such, we exclude non-field columns from the computation of grouped columns percentages.