Skip to content

[FIX] spreadsheet_oca: Odoo 19.0 compatibility fixes#108

Open
mpiko wants to merge 5 commits intoOCA:19.0from
mpiko:19.0-fix-odoo19-compat
Open

[FIX] spreadsheet_oca: Odoo 19.0 compatibility fixes#108
mpiko wants to merge 5 commits intoOCA:19.0from
mpiko:19.0-fix-odoo19-compat

Conversation

@mpiko
Copy link
Copy Markdown

@mpiko mpiko commented Mar 28, 2026

Relates to #73

  • Remove category_id and users fields from res.groups in security.xml
  • Rename groups_id to group_ids throughout
  • Update globalFiltersFieldMatchers to globalFieldMatchingRegistry API
  • Replace loadSpreadsheetDependencies with loadBundle
  • Restore force:true on actionRegistry.add
  • Remove duplicate chartSubtypeRegistry entries registered by Odoo 19
  • Add force:true to pivotSidePanelRegistry.add
  • Fix RELATIVE_DATE_RANGE_TYPES renamed to RELATIVE_PERIODS

mpiko added 2 commits March 28, 2026 13:03
- Remove category_id and users fields from res.groups in security.xml
- Rename groups_id to group_ids throughout
- Update globalFiltersFieldMatchers to globalFieldMatchingRegistry API
- Replace loadSpreadsheetDependencies with loadBundle
- Restore force:true on actionRegistry.add
- Remove duplicate chartSubtypeRegistry entries registered by Odoo 19
- Add force:true to pivotSidePanelRegistry.add
- Fix RELATIVE_DATE_RANGE_TYPES renamed to RELATIVE_PERIODS
- Remove category_id and users fields from res.groups (security.xml)
- Rename groups_id to group_ids throughout
- Update globalFiltersFieldMatchers to globalFieldMatchingRegistry API
- Replace removed loadSpreadsheetDependencies with loadBundle
- Restore force:true on actionRegistry.add
- Remove duplicate chartSubtypeRegistry entries registered by Odoo 19
- Add force:true to pivotSidePanelRegistry.add
- Fix RELATIVE_DATE_RANGE_TYPES renamed to RELATIVE_PERIODS

Note: pylint prefer-env-translation warnings in spreadsheet_dashboard.py,
spreadsheet_abstract.py and spreadsheet_spreadsheet.py are pre-existing
in the original module and out of scope for this fix.
@mpiko
Copy link
Copy Markdown
Author

mpiko commented Mar 28, 2026

Here's the PR description:


[FIX] spreadsheet_oca: Odoo 19.0 compatibility fixes

This PR fixes a series of breaking changes that prevent spreadsheet_oca and spreadsheet_dashboard_oca from loading on Odoo 19.0 Community Edition. All fixes have been verified against a running Odoo 19.0 instance.

Relates to #73


Python/XML changes

security/security.xml

  • Removed category_id and users fields from res.groups records — both removed in Odoo 19
  • Renamed groups_idgroup_ids in ir.rule domain expressions

views/spreadsheet_spreadsheet.xml

  • Renamed groups_idgroup_ids on ir.ui.menu record

JavaScript changes

bundle/filter.esm.js

  • globalFiltersFieldMatchers removed from global_filters_core_plugin — replaced by globalFieldMatchingRegistry from @spreadsheet/global_filters/helpers with updated method signatures (all methods now take getters as first argument)
  • RELATIVE_DATE_RANGE_TYPES removed from @spreadsheet/helpers/constants — replaced by RELATIVE_PERIODS from @spreadsheet/global_filters/helpers
  • Removed duplicate topbarMenuRegistry.add("file") and addChild("settings") registrations already present in Odoo 19

bundle/spreadsheet_renderer.esm.js

  • @spreadsheet/assets_backend/helpers and loadSpreadsheetDependencies removed in Odoo 19 — replaced with loadBundle("spreadsheet.o_spreadsheet") from @web/core/assets

bundle/spreadsheet_action.esm.js

  • actionRegistry.add("action_spreadsheet_oca") requires { force: true } as the action key is first registered by the lazy loader in web.assets_backend

bundle/odoo_panels.esm.js

  • All chartSubtypeRegistry.add(...) entries removed — these are now registered by the Odoo 19 community spreadsheet module and caused a registry conflict

bundle/filter_panel_datasources.esm.js

  • Added { force: true } to pivotSidePanelRegistry.add("ODOO") — already registered by Odoo 19 community module

Pre-existing issues not addressed in this PR

The following pylint prefer-env-translation warnings exist in the original module and are out of scope here:

  • spreadsheet_dashboard_oca/models/spreadsheet_dashboard.py lines 28, 30
  • spreadsheet_oca/models/spreadsheet_abstract.py line 70
  • spreadsheet_oca/models/spreadsheet_spreadsheet.py line 57

@mpiko mpiko mentioned this pull request Mar 28, 2026
2 tasks
@pedrobaeza
Copy link
Copy Markdown
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants