[19.0][FIX] database_cleanup: Avoid blocking uninstall during purge modules - #3669
Open
quoc-pn wants to merge 1 commit into
Open
Conversation
Member
|
Please check CI and remove |
quoc-pn
force-pushed
the
19.0-database_cleanup-uninstall-blocking-purge-modules
branch
from
July 14, 2026 07:16
411e350 to
9d145b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
The
button_immediate_uninstall()method raises aUserErrorwhen any module is in one of the following states:to install,to upgrade, orto remove.In the purge module workflow, modules to remove are updated to
to removebeforebutton_immediate_uninstall()is called to uninstall the installed modules. This causes the uninstall process to fail because the presence of modules in theto removestate blocksbutton_immediate_uninstall().Changes
Remove the logic that explicitly marks modules as
to remove.Use
module_uninstall()instead ofbutton_immediate_uninstall()to uninstall modules. Unlikebutton_immediate_uninstall(),module_uninstall()does not set the module state toto remove, allowing modules to be unlinked successfully.Note: The
_unlink_except_installed()method prevents unlinking modules whose state is one of the following:installed,to upgrade,to remove, orto install.