[18.0][FIX] autovacuum_message_attachment: Add missing message_type 'auto_comment' and allow to batch deletion - #3665
Open
divad1196 wants to merge 3 commits into
Open
Conversation
Contributor
|
Hi @florian-dacosta, |
OCA-git-bot
added
series:18.0
mod:autovacuum_message_attachment
divad1196
changed the title
divad1196
force-pushed
the
fix_vacuum_rule_message_type
branch
from
July 3, 2026 13:54
70113ae to
e6088fe
Compare
divad1196
marked this pull request as ready for review
July 3, 2026 13:54
divad1196
force-pushed
the
fix_vacuum_rule_message_type
branch
from
July 10, 2026 11:16
e6088fe to
039f8aa
Compare
divad1196
force-pushed
the
fix_vacuum_rule_message_type
branch
from
July 10, 2026 11:23
039f8aa to
9e35c6f
Compare
divad1196
commented
Jul 10, 2026
| with Registry(self.env.cr.dbname).cursor() as new_cr: | ||
| if batch_size == -1: | ||
| batch_size = len(self) | ||
| if not batch_size or batch_size < 0: |
Author
There was a problem hiding this comment.
TODO: use if not batch_size or batch_size < new_cr.IN_MAX: instead
simahawk
approved these changes
Jul 30, 2026
| with Registry(self.env.cr.dbname).cursor() as new_cr: | ||
| if batch_size == -1: | ||
| batch_size = len(self) | ||
| if not batch_size or batch_size < 0: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto_commentmessage_type was missing=> Add the option
=> Added
batch_sizeparameter to the rulessearchperformedorderbywhich forces an extra sort on the whole table=> Use
_searchinsteadunlinkis batched by Odoo natively, andbatch_unlinkwas also batching with its own value=> Make them use the same limit and added a batch size parameter to
batch_unlink