[19.0][FIX] database_cleanup: Added missing security rules for two models#3581
[19.0][FIX] database_cleanup: Added missing security rules for two models#3581OCA-git-bot merged 2 commits intoOCA:19.0from
Conversation
pedrobaeza
changed the title
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Now that we are here, shouldn't these permissions be adjusted for the admin group only?
wpichler
force-pushed
the
19.0-fix-database_cleanup
branch
from
7db800e to
0f2ef4f
Compare
|
i've changed it to base.group_system - force push... |
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Please check again, I don't see base.group_system in the access rules. Also, please mention the module name in the commit message.
wpichler
force-pushed
the
19.0-fix-database_cleanup
branch
2 times, most recently
from
a646546 to
4142f69
Compare
|
@StefanRijnhart You are right - sorry - made a commit without the changed file... Now it is correct |
StefanRijnhart
changed the title
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Can you please split the changes into 2: one for the switch from group_user to group_system, and the other adding the missing ACLs?
…dels from group base.group_user to base.group_system
wpichler
force-pushed
the
19.0-fix-database_cleanup
branch
from
4142f69 to
7688ccc
Compare
|
Ready to Merge... |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 793dd13. Thanks a lot for contributing to OCA. ❤️ |
4 participants
No description provided.