Conversation
- Add proper string conversion for non-string return values from Python code
in sequence evaluation to prevent TypeError during string concatenation
- Use isinstance check to only convert non-string values, preserving
original behavior for string results
- Add test case to verify handling of integer return values from Python code
- Use separate sequence in test to avoid interference with other tests
The fix ensures that when Python code in sequence evaluation returns
non-string values (like integers), they are properly converted to strings
before concatenation with prefix and suffix, preventing TypeError.
Fixes potential issue where Python expressions returning integers or
other non-string types would cause concatenation errors.
bosd
force-pushed
the
19-mig-sequence_python
branch
from
12ddf28 to
b9fca8c
Compare
|
/ocabot migration sequence_python |
|
Sorry @bosd you are not allowed to mark the addon to be migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
- Move UUID safe members computation to module level as a constant - Replace repeated computation in _get_python_eval_context with constant lookup - Use _UUID_SAFE_MEMBERS constant instead of computing uuid_elements on each call - Improves performance by avoiding redundant computation on every sequence evaluation This optimization pre-computes the UUID safe members list once at module import time instead of recomputing it on every call to _get_python_eval_context, which can happen frequently during sequence operations.
|
/ocabot migrationsequemce_pythom |
|
Hi @thomaspaulb. Your command failed:
Ocabot commands
More information
|
|
/ocabot migration sequence_python |
thomaspaulb
left a comment
thomaspaulb
left a comment
There was a problem hiding this comment.
Nice additions! Maybe add yourself as a contributor
|
This PR has the |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 64ca13e. Thanks a lot for contributing to OCA. ❤️ |
10 participants
based on unmerged: #3258