[17.0] impersonate_login: acl fix#951
Open
len-foss wants to merge 2 commits into
Open
Conversation
(cherry picked from commit c5545fe)
Avoid rewriting create_uid/write_uid on ir.attachment during impersonation. Temporary report/email attachments may be created without res_model/res_id and core access checks rely on creator ownership for read access in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks #913 and adapt #907 on top of it to address problems pointed in #902
Currently, the module is very useful for admins/debugging to check things as a user, especially in highly secure environment where you can't just pick up user passwords (enforced 2FAs, etc). However, these ACL issues break a number of basic user flows (like simply uploading an attachment in a message), actually rendering this very unreliable.