[FIX] auth_api_key: Read API key from headers#945
Open
SirPyTech wants to merge 1 commit into
Open
Conversation
SirPyTech
force-pushed
the
18.0-fix-auth_api_key-headers
branch
from
d9516b0 to
e035f31
Compare
Contributor
|
@simahawk wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, the API key is not being read from the headers.
It seems very strange to me that this is not working, but in my case it isn't, please let me know if I'm missing something.In the end, the problem was elsewhere, but I'll leave this here because it smells to have
headers = request.httprequest.environ: therequest'sheadersshould be assigned to theheadersvariable.