[18.0][FIX] report_xlsx: report xlsx/xlrd 2.0 compatibility#1081
Open
vincent-hatakeyama wants to merge 2 commits intoOCA:18.0from
Open
[18.0][FIX] report_xlsx: report xlsx/xlrd 2.0 compatibility#1081vincent-hatakeyama wants to merge 2 commits intoOCA:18.0from
vincent-hatakeyama wants to merge 2 commits intoOCA:18.0from
Conversation
Version 2.0 of xlrd does not handle xlsx anymore so use openxyl by default and fallback on xlrd.
vincent-hatakeyama
force-pushed
the
bugfix/18.0/report_xlsx/xlrd-2.0-compatibility
branch
from
9575715 to
e4be74c
Compare
Author
|
In #1078, the use of xlrd has been completely removed in favour of openpyxl. The same could be done here. |
HviorForgeFlow
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve added a skip of the tests if both library are absent; not sure it should stay.