[19.0][FIX] queue_job: add openupgradelib to external_dependencies#935
Open
fsmw wants to merge 1 commit into
Open
[19.0][FIX] queue_job: add openupgradelib to external_dependencies#935fsmw wants to merge 1 commit into
fsmw wants to merge 1 commit into
Conversation
Contributor
The module uses openupgradelib in migration scripts but it was not declared in external_dependencies, causing installation failures when openupgradelib is not already installed. Fixes OCA#809
fsmw
force-pushed
the
19.0-fix-queue_job-openupgradelib-809
branch
from
cd84a1d to
d943632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #809
Problem:
The module uses
openupgradelibin migration scripts (migrations/18.0.1.0.0/pre-migrate.py) but it was not declared inexternal_dependencies, causing installation failures whenopenupgradelibis not already installed.Fix:
Add
openupgradelibto theexternal_dependenciespython list in the manifest.Before:
After:
Fixes #809