[18.0][WIP] queue_job: run jobs in cron workers#871
Draft
sbidoul wants to merge 2 commits into
Draft
Conversation
Contributor
|
Hi @guewen, |
sbidoul
force-pushed
the
18.0-cron-jobrunner-sbi
branch
2 times, most recently
from
f038a2a to
13d3aa9
Compare
sbidoul
force-pushed
the
18.0-cron-jobrunner-sbi
branch
from
13d3aa9 to
3b6f3be
Compare
Member
Author
|
One thing I don't quite understand is why this can raise SELECT uuid FROM queue_job WHERE state='enqueued' LIMIT 1 FOR UPDATE SKIP LOCKED |
sbidoul
force-pushed
the
18.0-cron-jobrunner-sbi
branch
from
3b6f3be to
f6108a7
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This very WIP and draft and I'm not even sure this is useful.
One benefit is simpler deployment when the time limit of job workers has to be greater than the small time limit of interactive workers. In that (common) case configur the cron worker time limit would be sufficient instead of deploying another Odoo instance with different worker limits.
It builds on the refactoring done in #866, in particular the
_acquire_jobfunction and job execution class methods.The jobrunner still does the job scheduling (so with full support of channels etc), but
/queue_job/runjobtriggers crons which acquire jobs in ENQUEUED state and run them.Look at the last commit to understand how this works, it's pretty simple.