Skip to content

[FIX] project_task_pull_request: allow to put a pr_uri, without it is mandatory.#1688

Open
legalsylvain wants to merge 1 commit intoOCA:18.0from
grap:18.0-FIX-project_task_pull_request-optional-pr
Open

[FIX] project_task_pull_request: allow to put a pr_uri, without it is mandatory.#1688
legalsylvain wants to merge 1 commit intoOCA:18.0from
grap:18.0-FIX-project_task_pull_request-optional-pr

Conversation

@legalsylvain
Copy link
Copy Markdown
Contributor

Trivial

Rational: For the time being, a PR can be mandatory, if defined via pr_required_states settings. however, in some cases, user want to write this information, but not in all cases. So the field should not be hidden, even if it not required

… mandatory.

Rational: For the time being, a PR can be mandatory, if defined via pr_required_states settings. however, in some cases, user want to write this information, but not in all cases. So the field should not be hidden, even if it not required
Copy link
Copy Markdown

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants