[14.0][IMP] use cell_style_props for val_rendered in kpi matrix

[jonasbuchholz]

So far, the values set in set_values_detail_account were rendered using the row style properties, before evaluating the row's style expression. Thus, even though the correct style properties are passed as cell_style_props, some changes by the style_expression (e.g. prefix, suffix, ...) would not take effect.
With these changes, the style_expression gets evaluated before rendering the value, and the correct cell_style_props are passed to style_model.render.

[OCA-git-bot]

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

[sbidoul]

Hi @jonasbuchholz thanks for the contrib.

Can you post a few screenshot with a sample config to help me understand what this fixes ?

[jonasbuchholz]

Hi @sbidoul , thank you for your swift response!
Sure! One example would be a KPI that uses different rounding based on its value:

The style that is selected for the template in this case is "No Rounding". Without these changes, the rounding property is never applied to the values because the style_expression gets evaluated after they have been rendered:

If the rendering happens after evaluating the style_expression:

I hope this helps to explain what these changes do.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[sbidoul]

Thanks the change makes sense to me. I've not had time to look into it yet. Wondering how hard it would be to add a test for this.