lsp: fix toggleFormatOnSave - #869
Merged
horriblename merged 4 commits intoMay 8, 2025
Merged
Conversation
Noah765
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
April 30, 2025 08:46
Soliprem
approved these changes
Apr 30, 2025
Soliprem
left a comment
Soliprem
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Just to make sure I understand, the problem RN is that autoformat can't be disabled unless you enable null-ls?
Contributor
Author
Exactly |
horriblename
approved these changes
May 1, 2025
Owner
|
I meant to respond to this earlier, must've gotten to type out a reply. This is good for a merge, and I'll be merging once the CI passeed but it might be nice to ultimately port some of the changes in #768 again. Guessing it is now abandoned. |
|
✅ Preview has been deleted successfully! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.