docs: deprecated or inconsistent names#1495
Merged
NotAShelf merged 2 commits intoNotAShelf:mainfrom Apr 2, 2026
Merged
Conversation
When I tried this code I was getting an error `attribute 'neovim' missing`. When i changed it to `my-neovim` (from the other code above), it worked.
faretek1
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
NotAShelf
reviewed
Apr 1, 2026
`pkgs.stdenv.system` is deprecated Co-authored-by: raf <raf@notashelf.dev>
faretek1
changed the title
NotAShelf
changed the title
NotAShelf
approved these changes
Apr 2, 2026
Owner
|
Good catch, thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attribute 'neovim' missing. When i changed it tomy-neovim(from the other code above), it worked.pkgs.stdenv.systemwithpkgs.stdenv.hostPlatform.systemas per @NotAShelf 's advice (tested this on my machine)It may be worth adding a note in case anyone is using aarch64 or other architectures as well maybe, since I think that will cause an error with the
packages.x86_64-linux.my-neovim =line?I'm new to nix so I haven't done the stuff below other than testing it on my nixos config. But it's a really minor change so I hope it's ok!
Sanity Checking
This is a really minor PR and I am literally setting up nvf as I speak, so I'm not really sure about the stuff below
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.