Skip to content

theme/habamax: add neovim builtin theme habamax#1287

Closed
snoweuph wants to merge 1 commit intoNotAShelf:mainfrom
snoweuph:feature/habamax
Closed

theme/habamax: add neovim builtin theme habamax#1287
snoweuph wants to merge 1 commit intoNotAShelf:mainfrom
snoweuph:feature/habamax

Conversation

@snoweuph
Copy link
Copy Markdown
Collaborator

@snoweuph snoweuph commented Dec 14, 2025

Adding the neovim builtin theme habamax to the allowed themes with nvf.

Sanity Checking

[changelog]: https://github.com/NotAShelf/nvf/tree/main/docs/release-notes <-- deadlink (https://github.com/NotAShelf/nvf/blob/main/docs/manual/release-notes.md)
[hacking nvf]: https://notashelf.github.io/nvf/index.xhtml#sec-guidelines <-- deadlink (https://nvf.notashelf.dev/hacking.html)

  • I have updated the [changelog] as per my changes <-- should I create a new file for the 0.9 release, because 0.8 is already released?
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in [hacking nvf]
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 14, 2025

🚀 Live preview deployed from 62090f4

View it here:

Debug Information

Triggered by: snoweuph

HEAD at: feature/habamax

Reruns: 2137

@snoweuph
Copy link
Copy Markdown
Collaborator Author

rebased

github-actions bot pushed a commit that referenced this pull request Jan 23, 2026
@snoweuph snoweuph force-pushed the feature/habamax branch 2 times, most recently from 8836c6b to d266883 Compare January 24, 2026 18:23
@snoweuph
Copy link
Copy Markdown
Collaborator Author

@NotAShelf This is ready for merge

Soliprem
Soliprem previously approved these changes Jan 24, 2026
@snoweuph
Copy link
Copy Markdown
Collaborator Author

The editorconfig pipeline fail, is from the changelogs of another person :/

@NotAShelf
Copy link
Copy Markdown
Owner

I'm going to change this to a draft if you don't mind. While I could merge this (should be good for a merge after the conflict resolution), I'd like to avoid creating too many incompatibilities with the upcoming themeing refactor (#1262) and delay it longer than I already have.

@snoweuph
Copy link
Copy Markdown
Collaborator Author

I'm going to change this to a draft if you don't mind. While I could merge this (should be good for a merge after the conflict resolution), I'd like to avoid creating too many incompatibilities with the upcoming themeing refactor (#1262) and delay it longer than I already have.

Got it. hopefully all builtins will be available as options after the refactor and this isn't needed anymore?

@snoweuph snoweuph marked this pull request as draft January 29, 2026 05:25
@snoweuph snoweuph force-pushed the feature/habamax branch 2 times, most recently from 0634332 to 092d00d Compare February 1, 2026 22:48
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Feb 1, 2026

rebased

@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Feb 4, 2026

rebased

@snoweuph
Copy link
Copy Markdown
Collaborator Author

rebased -> showing I didnt forgot this and for my future sanity :D

github-actions bot pushed a commit that referenced this pull request Feb 18, 2026
@snoweuph
Copy link
Copy Markdown
Collaborator Author

rebased.
May Sanity stay ontop!

@snoweuph
Copy link
Copy Markdown
Collaborator Author

gruber-dark is in and actually works, so I have no reason to look after this further. though the builtin themes should prolly be added in the future some day

@snoweuph snoweuph closed this Mar 21, 2026
@snoweuph snoweuph deleted the feature/habamax branch March 21, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants