A job-level gate says the job level, not the class - #2294
Open
denislauri1999 wants to merge 1 commit into
Open
Conversation
The check is `JobLevel < LevelJobMinimum` and the answer was "you do not belong to the required class" - accusing the one thing that was fine. Reported from play as "NosCore will not let me wear an SP", with a reason pointing away from the cause: a Wild Keeper card needs job level 55, and a class change resets the job level to 1. The two messages were crossed. The class restriction is part of the combined level/sex/class gate further up, which sends CanNotWearThat; the job-level gate had the class message. Game18NConstString.CanNotBeWornLowJobLevel already existed and was unused. The sibling codebase answers "Your joblevel is too low!" on this same condition. The test asserts both halves: the job-level message is sent, and the class message is not. Being wrong here sends a real message on the right condition, so nothing raises - the player is just told the wrong reason.
|
Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check is
JobLevel < LevelJobMinimumand the answer wasCanNotBeWornDifferentClass— "you do not belong to the required class", accusing the one thing that was fine.The two messages are crossed. The class restriction is part of the combined level/sex/class gate further up, which sends
CanNotWearThat:Game18NConstString.CanNotBeWornLowJobLevelalready exists and was unused. OpenNos answersLOW_JOB_LVL("Your joblevel is too low!") on this same condition.Where it shows up in play: a Wild Keeper card needs job level 55, and a class change resets the job level to 1 — so the player is told they are the wrong class right after changing class, which is the most misleading moment possible.
The test asserts both halves: the job-level message is sent, and the class message is not. Being wrong here sends a real message on the right condition, so nothing raises — the player is just told the wrong reason.