feat: mate and family experience services - #129
Merged
erwan-joly merged 2 commits intoAug 23, 2026
Conversation
Two curves that were living in NosCore and belong here. MateExperienceService is the published curve divided by 20 for a pet and by 5 for a partner. Those divisors come from the XpLoad field of sc_p and sc_n in a packet capture: eleven observations between level 1 and level 88 match to the unit, including 29 312 950 and 39 495 200. Without them a pet needs twenty times the experience it should, which raises nothing and simply reads as slow progress. FamilyExperienceService is the published table as-is. A ginfo line from the same capture puts a level 7 family's bar at 640 000 where the table says 1 900 000, so at least that row is wrong — but one observation cannot rebuild the other eighteen, so the published numbers stand and the disagreement is noted where somebody will find it. Both come with approval-test tables under documentation/. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughAdded family and mate experience services. The services expose level-based experience requirements, handle unsupported levels, and generate ApprovalTests documentation for the supported ranges. ChangesExperience services
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This PR adds the mate and family experience services with documentation-backed tables. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
erwan-joly
reviewed
Aug 23, 2026
Two Vim .swp files were checked in alongside the approved documentation, and the two new approved files carried a BOM the generator does not emit - both are artefacts of hand-editing them. Ignoring *.swp so they cannot come back. Remarks cut back to the load-bearing facts, in line with the summary-only style of the services already here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving two curves out of NosCore, where you pointed out they do not belong (NosCoreIO/NosCore#2281 and NosCoreIO/NosCore#2283).
MateExperienceService— the published mate curve, divided by 20 for a pet and by 5 for a partner.Those divisors are not a guess. Every
XpLoadfield of everysc_pandsc_nin a packet capture matches the published curve after dividing — eleven observations from level 1 to level 88:Two eight-digit numbers landing exactly is not curve-fitting. Used raw, a pet needs twenty times the experience it should — and nothing throws, it just reads as slow progress.
FamilyExperienceService— the published table unchanged. Worth flagging: aginfoline from the same capture puts a level 7 family's bar at 640 000 where the table says 1 900 000. One observation cannot rebuild the other eighteen rows, so I left the published numbers and noted the disagreement in the remarks rather than inventing a correction.Both follow the existing services and come with approval-test tables under
documentation/.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Tests