Skip to content

restructure links and link types - #4390

Open
wavehassman wants to merge 6 commits into
developfrom
feature/onboarding-improvement
Open

restructure links and link types#4390
wavehassman wants to merge 6 commits into
developfrom
feature/onboarding-improvement

Conversation

@wavehassman

@wavehassman wavehassman commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Moves dashboard placement (guest home page, new member dashboard, onboarding dashboard) off the shared link type and onto individual links, so the same link type can now be reused across a project link and any number of dashboards instead of being tied to one placement
  • Also cleans up a handful of related rough edges: a database transaction now protects the useful-links save so a failed request can't wipe out an org's existing links, the migration backfill makes sure old data doesn't end up assigned to more than one dashboard, and a couple of frontend components were fixed so save failures actually show an error instead of silently closing or getting stuck on a loading spinner

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

@wavehassman
wavehassman requested a review from staysgt August 20, 2026 01:51
@wavehassman
wavehassman marked this pull request as ready for review August 20, 2026 01:51

@staysgt staysgt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason that you chose to do this with the three separate fields instead of an enum field for a link's page? In terms of clicking around on the frontend it doesn't seem like theres a way to have a link set to more than one page, and I think an enum would make some of the logic more straightforward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants