#4302 dropdown autofill autocomplete - #4383
Open
staysgt wants to merge 1 commit into
Open
Conversation
wavehassman
requested changes
Aug 20, 2026
wavehassman
left a comment
wavehassman
left a comment
Contributor
There was a problem hiding this comment.
at src/frontend/src/utils/themes.ts:73:
This should be a MuiAutocomplete theme default
This would match the existing MuiButtonBase/MuiList pattern here, rather than editting each one
^ this would prob work better
| <FormControl fullWidth> | ||
| <FormLabel>Tags (Optional)</FormLabel> | ||
| <Autocomplete | ||
| autoHighlight |
Contributor
There was a problem hiding this comment.
autoHighlight auto-selects the prepended "Add New" sentinel option on empty input
Enter now opens the create-tag modal instead of picking a tag
Needs autoHighlight={false} so "Add New" isn't index 0
| if (multiple) { | ||
| return ( | ||
| <Autocomplete | ||
| autoHighlight |
Contributor
There was a problem hiding this comment.
autoHighlight was added to the multiple-branch only
the single-select branch (used by ProjectDropdown in TaskFormModal.tsx) is missing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When typing in an autocomplete dropdown menu, pressing 'enter' will autofill the top most/selected user.
Notes
I looked into creating an abstracted component for autcompletes with multiple, but they all followed different patterns/had different UIs implemented. Still happy to implement that if you think its better than adding the autohighlight everywhere
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4302