Skip to content

#4286 add rule status to general view#4307

Merged
wavehassman merged 3 commits into
feature/rules-dashboardfrom
#4286-rules-toggle-status-in-general-view
Jul 6, 2026
Merged

#4286 add rule status to general view#4307
wavehassman merged 3 commits into
feature/rules-dashboardfrom
#4286-rules-toggle-status-in-general-view

Conversation

@cielbellerose

@cielbellerose cielbellerose commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Changes

Added statuses (and ability to update them) to general view

Updated formatting for general and team view to match project detail view

Notes

More formatting updates will be added in #4280 to better match the epic

Screenshots

Screenshot 2026-07-06 at 2 16 42 PM Screenshot 2026-07-06 at 2 17 22 PM Screenshot 2026-07-06 at 2 43 05 PM

To Do

  • team view formatting

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4286

@cielbellerose cielbellerose changed the title #4286 moved rule status logic and added to general view #4286 add rule status to general view + update formatting Jul 6, 2026
@cielbellerose cielbellerose changed the title #4286 add rule status to general view + update formatting #4286 add rule status to general view Jul 6, 2026
@cielbellerose cielbellerose self-assigned this Jul 6, 2026
const isPopoverOpenForRule = Boolean(statusPopoverAnchor) && selectedProjectRule?.rule.ruleId === rule.ruleId;

return (
<Box sx={{ display: 'inline-flex', alignItems: 'center', gap: 0.5 }}>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved into RuleStatusTag

return allRules.filter((rule) => !rule.parentRule);
}, [allRules]);

// Helper function to get all descendant leaf rules for a given rule

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved into util functions

@cielbellerose cielbellerose requested a review from wavehassman July 6, 2026 18:52
@cielbellerose cielbellerose marked this pull request as ready for review July 6, 2026 18:52
@wavehassman wavehassman merged commit a67132c into feature/rules-dashboard Jul 6, 2026
4 checks passed
@wavehassman wavehassman deleted the #4286-rules-toggle-status-in-general-view branch July 6, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants