Skip to content

Onboarding/slack id entry#4301

Draft
getheobald wants to merge 5 commits into
feature/onboarding-improvementfrom
onboarding/slack-id-entry
Draft

Onboarding/slack id entry#4301
getheobald wants to merge 5 commits into
feature/onboarding-improvementfrom
onboarding/slack-id-entry

Conversation

@getheobald

@getheobald getheobald commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Changes

Current routing:

  • Sign up, guest, /home shows IntroGuestHomePage
  • Click join NER and select subteam, /home shows /home/pnm (PNMHomePage)
  • Finish recruiting dashboard, goes to /home/onboarding
  • Click finish, history.push(routes.HOME_ACCEPT), AcceptedPage
  • Click Accept, completedOnboarding now true, redirects to /home, renders GuestHomePage since still guest role

Changes I made:

  • Have handleConfirmModal on onboarding page call completeOnboarding() and redirect to slack id page
  • Get rid of AcceptedPage entirely
  • Add persistent gate in AppAuthenticated - nvm, this already exists (SetUserPreferences)
    • Change if to (isGuest(userRole) && !completedOnboarding)
    • Pass in completedOnboarding from AppPublic
  • New backend validation endpoint because rn SetUserPreferences doesn't do any validation

Notes

How important is it for me to tag commits with ticket number? I keep forgetting

Screenshots

If you made UI changes you must post a screenshot of the whole page for each change in 1) a normal sized window and 2) the smallest possible window

If you did any manual testing (e.g., with Postman), put screenshots of the http request and before and after of the db

If none of this applies, you can delete this section

To Do

Need to figure out if window.location.reload() is necessary

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4137

@getheobald getheobald self-assigned this Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant