Skip to content

#4284 fix project rules#4289

Open
cielbellerose wants to merge 16 commits into
feature/rules-dashboardfrom
#4284-fix-project-rules
Open

#4284 fix project rules#4289
cielbellerose wants to merge 16 commits into
feature/rules-dashboardfrom
#4284-fix-project-rules

Conversation

@cielbellerose

@cielbellerose cielbellerose commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Changes

Rules assigned to a project now show up in the project detail view

This pr also removed REVIEW as a rule status, and changed status to a universal isCompleted boolean for individual rules.

  • Completed rules include a tooltip mentioning who completed them, and mentions if they were completed in a specific project

Notes

  • Formatting for the project rules was updated to better match the epic
  • Added link to the assign rules page from the project detail view
  • Added name of currently active ruleset for each ruleset type tab
  • Also updated seed data for rulesets (and project rules) to utilize real rules from past competition rule docs

Screenshots

Screenshot 2026-06-25 at 2 22 19 PM Screenshot 2026-06-25 at 2 33 19 PM Screenshot 2026-06-25 at 2 33 54 PM
Screen.Recording.2026-06-25.at.2.31.01.PM.mov

To Do

  • set up bodywork seeded project rules
  • a rule in a team should be able to be added to multiple projects for that team, not one project per team its assigned to
  • Add the name of the active ruleset for this ruleset type in the project detail view
  • add a link to the assign rules page for each ruleset type (in case adding rules is confusing)

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4284

@cielbellerose cielbellerose self-assigned this Jun 24, 2026
@cielbellerose cielbellerose marked this pull request as ready for review June 25, 2026 22:50
Comment thread src/backend/src/prisma/migrations/20260623194325_rule_completion/migration.sql Outdated
Comment thread src/backend/src/controllers/rules.controllers.ts Outdated
Comment thread src/backend/src/controllers/rules.controllers.ts
@cielbellerose cielbellerose requested a review from wavehassman July 4, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants