Skip to content

Adding toggle for who to notify on Slack#4205

Open
EdgarButtner wants to merge 2 commits into
developfrom
#4093-Team-vs-Channel-Slac-Notifications
Open

Adding toggle for who to notify on Slack#4205
EdgarButtner wants to merge 2 commits into
developfrom
#4093-Team-vs-Channel-Slac-Notifications

Conversation

@EdgarButtner
Copy link
Copy Markdown
Contributor

@EdgarButtner EdgarButtner commented May 13, 2026

Changes

I added a frontend toggle to the create and edit event form on the calendar page. You can now choose between notifying individuals and channels. To save who the event wants to notify I added a field to the Event model in schema.prisma. This allows us to correctly save and render the toggle in the frontend when editing an event and seemed to me like the best way to do this.

Notes

I think modifying schema.prisma was the right way to do this but if not please let me know and I'll change it ASAP.

Test Cases

  • Added test @user is set as default
  • Added test making sure @channel persists across page refreshes and is stored correctly

Screenshots

See Toggle to the right of the notiification section
Screenshot 2026-05-13 at 2 26 07 PM

To Do

Make Tests

  • Tests for who we choose to notify

Checklist

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4093

Copy link
Copy Markdown
Contributor

@staysgt staysgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, just two small comments, one above and: in calendar.routes.ts, in the create/edit event routes, validate the mention parameter

export enum SlackMentionType {
USER = 'user',
CHANNEL = 'channel'
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small, but these should be all caps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintenance] - Team vs Channel Slack Notif @ for Events

2 participants