Adding toggle for who to notify on Slack#4205
Open
EdgarButtner wants to merge 2 commits into
Open
Conversation
…nt is schema.prisma, as well as notification capabilities
staysgt
requested changes
May 14, 2026
Contributor
staysgt
left a comment
There was a problem hiding this comment.
Looks really good, just two small comments, one above and: in calendar.routes.ts, in the create/edit event routes, validate the mention parameter
| export enum SlackMentionType { | ||
| USER = 'user', | ||
| CHANNEL = 'channel' | ||
| } |
Contributor
There was a problem hiding this comment.
small, but these should be all caps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I added a frontend toggle to the create and edit event form on the calendar page. You can now choose between notifying individuals and channels. To save who the event wants to notify I added a field to the Event model in schema.prisma. This allows us to correctly save and render the toggle in the frontend when editing an event and seemed to me like the best way to do this.
Notes
I think modifying schema.prisma was the right way to do this but if not please let me know and I'll change it ASAP.
Test Cases
Screenshots
See Toggle to the right of the notiification section

To Do
Make Tests
Checklist
yarn.lockchanges (unless dependencies have changed)Closes #4093