#4048 tasks for work packages by getheobald · Pull Request #4098 · Northeastern-Electric-Racing/FinishLine

getheobald · 2026-03-27T02:11:41Z

Changes

There's a new Tasks tab on work packages that shows tasks associated with that work package. The project tasks tab shows all tasks associated with that project, including tasks on its wp's tasks. A task's WP can be edited or deleted.

Backend

Task schema already had wbsElement field which can be a project or wp (or car), but there was nothing above schema level that supported it
Changed getWorkPackageQueryArgs to return task info so transformer can get tasks from it
Changed project transformer to include all the project's wp's tasks
Added editTaskWbsElement throughout stack to handle edits

Frontend

Added optional WP dropdown to new task modal on Project tasks tab
Display WP chip on task card on Project tasks tab but not WP tasks tab
Added WP line to task detail modal on Project tasks tab
Made sure Project tasks tab shows all its tasks and all its work packages' tasks
Show tasks tab on WP detail page, filtered for only that WP's tasks
Don't show WP dropdown on WP tasks page

Notes

Do people ever create tasks from the gantt chart? Just realized you can, and I didn't put the WP dropdown on the new task modal that pops up from gantt chart. I could, but does anyone even do that? It's also super easy to edit once you're back on the project page. But I can add that in if you want.
I can change the color/design of the chip!!!! Super open to changes there
validateInputs was missing from some post requests in tasks routes so I added it but I know that was out of the scope of this ticket
Teams references in the tasks frontend weren't used anywhere so I deleted them
There's technically a known theoretical edge case I didn't prevent against but there's like no way for it to ever happen unless someone adds in Work Package selection UI in WP tasks page (why would you) ... if workPackages is undefined (i.e. the task is on a WP) AND somehow wpWbsNum is set, targetWbsElementId would be undefined, so the if (targetWbsElementId) check fails the api call is skipped and the WP change is never saved, but no error is shown. But this won't happen in practice because the WP dropdown is hidden in the WP context so wpWbsNum can never be set to anything new there

Test Cases

Throw error when guests try to edit work package
Throw error when task doesn't exist
Throw error when task was deleted
Throw error when new work package doesn't exist
Throw error when new work package was deleted
Successfully update work package

Screenshots

Task Form Modal in projects page tasks tab

Task Modal on projects page tasks tab shows wp as line item

Projects page, containing tasks associated with wps

You can't see my cursor but they're clickable and highlight when hovered over

WP page now has a tasks tab, filtered for only that wp's tasks, which don't show chips because they're obviously on that wp

No option to choose wp when creating task from wp page - they're automatically associated with the relevant wp

Checklist

Closes #4048

…p tasks

…s element error but bedtime

…al but editing still broken

…rk-packages

…t works!

…ject

…p tasks tab

chpy04

Good start, couple notes:

If I'm editting a task from the wp task kanban, I should still be able to change the task's work package
I should be able to edit a task and remove the work package
Saw ur slack but yes we need to support select a wp via gantt chart as well

chpy04 · 2026-03-27T17:50:17Z

src/backend/src/controllers/tasks.controllers.ts

    }
  }

+  static async editTaskWbsElement(req: Request, res: Response, next: NextFunction) {


Unless we have different permissions (which I don't think we do) we should just add a wbselement param to the edit and then use that route instead of this

yeah makes sense. I separated it cause I saw that assignees and status were separated but I guess those have valid reasons and this doesn't, so I'll throw it in with editTask

chpy04 · 2026-03-27T17:52:35Z

src/backend/src/prisma-query-args/work-packages.query-args.ts

          blocking: { where: { wbsElement: { dateDeleted: null } }, include: { wbsElement: true } },
-          descriptionBullets: { where: { dateDeleted: null }, ...getDescriptionBulletQueryArgs(organizationId) }
+          descriptionBullets: { where: { dateDeleted: null }, ...getDescriptionBulletQueryArgs(organizationId) },
+          tasks: { where: { dateDeleted: null }, ...getTaskQueryArgs(organizationId) }


I'm a little concerned about adding this much nested information to the generic work package query args. Can we instead make a seperate endpoint to get the tasks for a specific work package and then use that? Could also just make a get task by wbs element and then abstract it for both project and wp task page

chpy04 · 2026-03-27T17:53:29Z

src/backend/src/prisma/seed.ts

      'easy to forget McCauley, in his blue racing jacket and jet black helmet, is racing laps around the roof of ' +
      "Columbus Parking Garage on Northeastern's Boston campus. But that's the reality of Northeastern Electric " +
-      'Racing, a student club that has made due and found massive success in the world of electric racing despite its ' +
+      'Racing, a student club that has made do and found massive success in the world of electric racing despite its ' +


chpy04 · 2026-03-27T17:55:20Z

src/backend/src/services/tasks.services.ts

+        },
+        workPackage: {
+          include: {
+            project: {


you already have this information at the project level above so this is redundant

It's not, because project and wp are mutually exclusive on a wbs element. If createTask is called on a project, requestedWbsElement.project is populated and requestedWbsElement.workPackage is null, and vice versa for if called on a wp. So I think we need both full includes in the query because only one will actually return.

chpy04 · 2026-03-27T17:55:55Z

src/backend/src/services/tasks.services.ts

+   * @returns the updated task
+   * @throws if the task does not exist, the task is already deleted, the wbs element doesn't exist, or if the user does not have permissions
+   */
+  static async editTaskWbsElement(


same as above, lets just group this in with edit task

chpy04 · 2026-03-27T18:02:30Z

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/TaskList/v2/TaskColumn.tsx

-  project: Project;
+  wbsNum: WbsNumber;
+  wbsElementId: string;
+  workPackages?: WorkPackage[];


same thing here the task column component should not need a list of work packages

chpy04 · 2026-03-27T18:04:34Z

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/TaskList/v2/TaskListContent.tsx

+  tasks: Task[];
+  wbsNum: WbsNumber;
+  wbsElementId: string;
+  workPackages?: WorkPackage[];


chpy04 · 2026-03-27T18:07:53Z

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/TaskList/TaskFormModal.tsx

  title: yup.string().required(),
-  taskId: yup.string().required()
+  taskId: yup.string().required(),
+  wpWbsNum: yup.mixed<WbsNumber>().optional()


Pretty sure yup.mixed is used when it could be one of a number of different primative types. In this case you could just do string. If you wanted to specifcally ensure its a wbsnumber you could add a test function for that but because users aren't manually typing in numbers I think its fine to just say string.

chpy04 · 2026-03-27T18:07:59Z

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/TaskList/TaskFormModal.tsx

  onHide: () => void;
  onSubmit: (data: EditTaskFormInput) => Promise<void>;
  onReset?: () => void;
+  workPackages?: WorkPackage[];


chpy04 · 2026-03-27T18:08:57Z

src/shared/src/types/project-types.ts

  teamTypes: TeamType[];
  projectId: string;
  events: EventPreview[];
+  tasks: Task[];


same, would really like to remove this

getheobald · 2026-03-27T18:54:06Z

Good start, couple notes:

If I'm editting a task from the wp task kanban, I should still be able to change the task's work package

I should be able to edit a task and remove the work package

Saw ur slack but yes we need to support select a wp via gantt chart as well

That was a design decision - ticket specified that I should lock wp selection within wp task kanban (I decided to omit it entirely). I can change it if you like! I don't want to let users create a task with any wp from wp task kanban, partly because it doesn't make sense and partly because people will get confused if they accidentally click the wrong one and then the created task doesn't appear anywhere on the page, but if editing is important I could add that
You can; there's an X on the right side of the dropdown. Do you think it needs to be more visually obvious? (UX question not insult)
Ok will add

getheobald · 2026-03-27T19:00:16Z

I lied I read the ticket more carefully and I guess the main spec was that it's locked in the wp task kanban creation modal, but I do see the value of editing there. So yes I'll add that back in!

chpy04 · 2026-03-27T19:05:08Z

I think its always better to give the user the option so I'd prefer to always let them edit the wp but then if they create from within a work package it should default to the wp they are in so lets always have the field regardless. In terms of removing the wp, when I tested it the x wasn't working for editting an already created task on a wp, but let me know if you are unable to reproduce

getheobald added 18 commits March 23, 2026 16:53

#4048 wp query args and project transformer edits to start fetching w…

3ff416c

…p tasks

#4048 finish backend transformer and query arg updates

a230f8e

#4048 task card, column, and taskformmodal updates - still getting wb…

48f6399

…s element error but bedtime

#4048 fixed create task wbs check, chip now showing, updated task mod…

300fb60

…al but editing still broken

Merge remote-tracking branch 'origin/develop' into #4048-tasks-for-wo…

eec2ab2

…rk-packages

#4048 revert overview and preview task include

1c111ac

#4048 added editTaskWbsElement across stack to handle edits and now i…

35ea413

…t works!

#4048 wp tasks page with one-line filter, pre-refactor

99f3d44

#4048 refactor task frontend to accept piecemeal props instead of pro…

b8e54af

…ject

#4048 revert filter change and call TLC directly from WPVC

524b3a0

#4048 conditionally render wp dropdown, truncate chip, omit chip on w…

5047191

…p tasks tab

#4048 remove dead teams code from task frontend

5cc4512

#4048 clickable chip

5ab8d0f

#4048 extraneous imports

a324ab9

#4048 unit tests

b4832e7

#4048 lint

359e27d

#4048 tsc check and prettier

4f6f675

#4048 freaking commas

723e5f1

getheobald self-assigned this Mar 27, 2026

#4048 omg tsc check everything needs a wbsName

f4232a0

getheobald requested review from Steph375, chpy04 and cielbellerose March 27, 2026 03:25

chpy04 requested changes Mar 27, 2026

View reviewed changes

getheobald added 3 commits March 27, 2026 23:18

#4048 remove wp-task association in types, transformers, and query args

094ef6b

#4048 full getTasksByWbsElement endpoint

af1cf4d

#4048 revert tasklist props

4ccc6ea

Conversation

getheobald commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Test Cases

Screenshots

Checklist

Uh oh!

chpy04 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

getheobald commented Mar 27, 2026

Uh oh!

getheobald commented Mar 27, 2026

Uh oh!

chpy04 commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

getheobald commented Mar 27, 2026 •

edited

Loading