#3881 create select material to copy modal#4059
Open
samshr27 wants to merge 9 commits intofeature/bom-improvement-pt2from
Open
#3881 create select material to copy modal#4059samshr27 wants to merge 9 commits intofeature/bom-improvement-pt2from
samshr27 wants to merge 9 commits intofeature/bom-improvement-pt2from
Conversation
samshr27
force-pushed
the
#3881-create-select-material-to-copy-modal
branch
from
928624a to
de9fffc
Compare
samshr27
changed the base branch from
feature/bom-improvements
to
feature/bom-improvement-pt2
samshr27
force-pushed
the
#3881-create-select-material-to-copy-modal
branch
from
0d7e1fc to
16847a9
Compare
wavehassman
requested changes
Mar 19, 2026
Contributor
wavehassman
left a comment
wavehassman
left a comment
There was a problem hiding this comment.
Awesome work so far! Here are some things to look at on top of the review:
- materialToOption shows assemblyId, we want it to show assembly name
- you do not want to copy the status
- the copyFromExistingBomAction prop is declared, but never used in the MaterialFormView file
- you need to set reimbursement request id to undefined explicitly when copying the material
- the drop downs are confusing because the car number just shows 0 or 1 and someone just opening it has no idea what that is referring to. I would show "Car _" so they know it's a car
- add a search icon or something to the search bar to differentiate it from the other drop downs, also take out the label
|
|
||
| const [copyModalOpen, setCopyModalOpen] = React.useState(false); | ||
|
|
||
| const handleCopySelect = (m: any) => { |
| sortable: false, | ||
| filterable: false, | ||
| hide: hideColumn[3], | ||
| renderCell: (params) => { |
Contributor
There was a problem hiding this comment.
this should still be there, probably just a merge mix up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added the 'Select Material to Copy' modal: lets you copy over information from a previous material from a car/project of your choosing.
Edited the MaterialFormView to allow the COPY FROM EXISTING BOM button to function
Edited the team.utils to allow a 'Copy' SubmitText
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3881