Conversation
superhvarn
requested changes
Sep 24, 2025
gcooper407
previously approved these changes
Sep 29, 2025
Contributor
gcooper407
left a comment
There was a problem hiding this comment.
thanks for making those fixes, looks good!
walker-sean
requested changes
Oct 29, 2025
Member
walker-sean
left a comment
There was a problem hiding this comment.
Can we make this standard for how we handle dates in the frontend and backend to avoid this issue in other places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix start date off-by-one bug by normalizing client-provided dates to the user’s local midnight converted to UTC before persisting.
Notes
This change is timezone agnostic, so if someone in another timezone chooses a day (e.g. 9/24/25) for the start date, this is the date for everyone else.
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #1192