Skip to content

Feature/p3t1755 #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caiodasilva2005 merged 6 commits into from
Mar 20, 2026
Merged

Feature/p3t1755 #379

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c576493
fixed p3t bitshift
aolgeirson Mar 13, 2026
6dbd277
progress on raw to temp
aolgeirson Mar 15, 2026
0b337d4
int |-> float fixed p3t readings
aolgeirson Mar 20, 2026
100e305
Merge branch 'main' into feature/p3t1755
caiodasilva2005 Mar 20, 2026
f6b9631
fix header
caiodasilva2005 Mar 20, 2026
df9cd91
format
caiodasilva2005 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 33 additions & 27 deletions general/include/p3t1755.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,22 @@

#ifndef p3t1755_H
#define p3t1755_H
#include <stdint.h>
#include <math.h>
#include <stdint.h>

// REGISTERS
// Temperature register: contains two 8-bit data bytes; to store the measured Temp data.
// Temperature register: contains two 8-bit data bytes; to store the measured
// Temp data.
#define p3t1755_TEMPERATURE 0x00 // read only
// Configuration register: contains a single 8-bit data byte; to set the device operating condition
// Configuration register: contains a single 8-bit data byte; to set the device
// operating condition
#define p3t1755_CONFIGURATION 0x01
// T_low register: Hysteresis register, it contains two 8-bit data bytes to store the hysteresis T_low limit; default = 75 °C.
// T_low register: Hysteresis register, it contains two 8-bit data bytes to
// store the hysteresis T_low limit; default = 75 °C.
#define p3t1755_T_LOW 0x02
// T_high register: Overtemperature shut down threshold register, it contains two 8-bit data bytes to
// store the overtemperature shutdown T_high limit; default = 80 °C.
// T_high register: Overtemperature shut down threshold register, it contains
// two 8-bit data bytes to store the overtemperature shutdown T_high limit;
// default = 80 °C.
#define p3t1755_T_HIGH 0x03

// TEMPERATURE REGISTER FORMAT
Expand All @@ -26,56 +30,58 @@
#define p3t1755_TEMP_MAX 125.0f

#define p3t1755_RAW_TO_CELSIUS(raw) (((int16_t)(raw)) * p3t1755_TEMP_RESOLUTION)
#define p3t1755_CELSIUS_TO_RAW(temp) \
((uint16_t)((int16_t)((temp) / p3t1755_TEMP_RESOLUTION)))
#define p3t1755_CELSIUS_TO_RAW(temp) \
((uint16_t)((int16_t)((temp) / p3t1755_TEMP_RESOLUTION)))

// CONFIGURATION MASKS
#define p3t1755_SHUTDOWN_MODE_MASK 0x01 // Bit 0
#define p3t1755_SHUTDOWN_MODE_MASK 0x01 // Bit 0
#define p3t1755_THERMOSTAT_MODE_MASK 0x02 // Bit 1
#define p3t1755_POLARITY_MASK 0x04 // Bit 2
#define p3t1755_FAULT_QUEUE_MASK 0x18 // Bits 4-3
#define p3t1755_POLARITY_MASK 0x04 // Bit 2
#define p3t1755_FAULT_QUEUE_MASK 0x18 // Bits 4-3
#define p3t1755_CONVERSION_TIME_MASK 0x60 // Bits 6-5
#define p3t1755_ONE_SHOT_MASK 0x80 // Bit 7
#define p3t1755_ONE_SHOT_MASK 0x80 // Bit 7

// FAULT QUEUE SETTINGS
#define p3t1755_1_CONSECUTIVE_FAULT 0x00
#define p3t1755_1_CONSECUTIVE_FAULT 0x00
#define p3t1755_2_CONSECUTIVE_FAULTS 0x08 // default
#define p3t1755_4_CONSECUTIVE_FAULTS 0x10
#define p3t1755_6_CONSECUTIVE_FAULTS 0x18

// CONVERSION TIME SETTINGS
#define p3t1755_27_5MS_CONVERSION_TIME 0x00
#define p3t1755_55MS_CONVERSION_TIME 0x20 // default
#define p3t1755_110MS_CONVERSION_TIME 0x40
#define p3t1755_220MS_CONVERSION_TIME 0x60
#define p3t1755_55MS_CONVERSION_TIME 0x20 // default
#define p3t1755_110MS_CONVERSION_TIME 0x40
#define p3t1755_220MS_CONVERSION_TIME 0x60

// Function Pointers
typedef int32_t (*WritePtr)(uint16_t dev_addr, uint16_t reg, uint8_t *data,
uint8_t length);
uint8_t length);
typedef int32_t (*ReadPtr)(uint16_t dev_addr, uint16_t reg, uint8_t *data,
uint8_t length);
uint8_t length);

typedef struct {
uint16_t dev_addr;
WritePtr write;
ReadPtr read;
uint16_t dev_addr;
WritePtr write;
ReadPtr read;
} p3t1755_t;

static inline float p3t1755_raw_to_celsius(uint16_t raw);
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header declares static inline float p3t1755_raw_to_celsius(uint16_t raw); but does not provide a definition. A static inline function should be defined in the header (so each translation unit can inline it), or it should be declared as a normal extern function and defined once in the .c file. As-is, any use from another .c file will fail to link/compile depending on compiler settings.

Suggested change
static inline float p3t1755_raw_to_celsius(uint16_t raw);
static inline float p3t1755_raw_to_celsius(uint16_t raw) {
return ((int16_t)raw) * p3t1755_TEMP_RESOLUTION;
}

Copilot uses AI. Check for mistakes.

void p3t1755_init(p3t1755_t *p3t, WritePtr write, ReadPtr read,
uint16_t dev_addr);
uint16_t dev_addr);

int p3t1755_read_reg(p3t1755_t *p3t, uint16_t reg, uint8_t *data,
uint8_t length);
uint8_t length);
int p3t1755_write_reg(p3t1755_t *p3t, uint16_t reg, uint8_t *data,
uint8_t length);
uint8_t length);

// Reads current temp in celcius
int p3t1755_read_temperature(p3t1755_t *p3t, float *temp_c);

// Config functions
int p3t1755_configure(p3t1755_t *p3t, uint8_t shutdown, uint8_t thermostat,
uint8_t polarity, uint8_t fault_queue,
uint8_t conversion_time);
uint8_t polarity, uint8_t fault_queue,
uint8_t conversion_time);
int p3t1755_set_shutdown_mode(p3t1755_t *p3t, uint8_t enable);
int p3t1755_set_thermostat_mode(p3t1755_t *p3t, uint8_t enable);
int p3t1755_set_one_shot_mode(p3t1755_t *p3t, uint8_t enable);
Expand All @@ -90,4 +96,4 @@ int p3t1755_read_low_temp(p3t1755_t *p3t, float *temp_c);
int p3t1755_set_high_temp(p3t1755_t *p3t, float temp_c);
int p3t1755_set_low_temp(p3t1755_t *p3t, float temp_c);

#endif
#endif
Loading
Loading