-
Notifications
You must be signed in to change notification settings - Fork 1
#668 - Branch-based planning pipeline and ai-workflow label #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bracyw
wants to merge
15
commits into
develop
Choose a base branch
from
claude/grill-docs-build-pipeline-75qv28
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−4
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
31574a2
#668 - add branch-based research pipeline and ai-workflow label
claude f155c3d
#668 - rename research pipeline to planning pipeline
claude a010c4c
#668 - clarify the planning flow starts with grill-with-docs
claude 8eaa6e6
#668 - frame the planning pipeline as the default, not heavy-ticket-only
claude 6e2fa39
#668 - tighten planning-pipeline docs and skill prose
claude 8f29477
#668 - address PR review: parent link, ticket close, PRD retention, t…
bracyw 14f655f
#668 - review nits: tighten agent-skills sentence, move Planning tick…
bracyw 7dcaba8
#668 - address review: fix pipeline contradictions
claude e3399d2
#668 - PRD home is a GitHub issue; docs/planning is temporary staging
claude e9bd3c0
#668 - finalize model: PRD epic parents sub-tickets, 3 phased PRs, ma…
claude 9effb2e
#668 - remove dogfood PRD; PRD files are temporary, not committed to …
claude 8e65c6a
#668 - ai-workflow is a single label; drop the type/difficulty clause
claude afcb936
#668 - PRD stays a PRD issue, not relabeled to an epic
claude 6df3006
#668 - ticket drafts live under a tickets/ subfolder of the PRD folder
claude 7eae913
#668 - move planning artifacts to docs/prd/<ticket>/, tickets as flat…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Branch-based planning pipeline for AI-authored issues | ||
|
|
||
| The AI issue-authoring flow (grill-with-docs to-prd to-issues triage) produced its research, terminology, ADRs, and PRD inside one ephemeral chat session, then filed implementation issues from chat with no review gate. Argos moves that flow onto a branch: a planning ticket opens the work, the session's artifacts (CONTEXT.md edits, ADRs, PRD) are committed to the branch, and it's reviewed as a draft PR against develop before any issues spawn. Issues are broken out after merge. A new ai-workflow label marks tickets whose subject is the AI dev workflow itself. | ||
|
|
||
| ## Considered Options | ||
|
|
||
| - Keep the chat-only flow: file implementation issues directly from the planning session. Rejected — no durable, reviewable record of the reasoning, and issues spawn before anyone reviews the plan. | ||
| - Commit the artifacts but skip the planning ticket and PR review gate. Rejected — it keeps the artifacts but loses the review step, which is the whole point. | ||
| - Name it the "research pipeline." Rejected — the flow is more than research; it covers terminology, ADRs, and PRD authoring through to issue breakout. | ||
|
|
||
| ## Why branch-based | ||
|
|
||
| - Planning artifacts become reviewable git history. The PRD and any ADRs land in a PR diff teammates can comment on before the work fans out into issues. | ||
| - A planning ticket gives the branch a tracked entry point, consistent with the existing {issue}-{kebab-title} branch convention — no new branch namespace to learn. | ||
| - Reviewing the plan before it fans out means the tickets that get created reflect an approved PRD, not a chat draft nobody signed off on. | ||
| - The ai-workflow label gives meta-work (changes to the skills and docs/agents themselves) a first-class category, instead of mis-filing it under a product area label. | ||
|
|
||
| ## Consequences | ||
|
|
||
| - Hierarchy: planning ticket → PRD (published as an issue that links to the planning ticket) → implementation tickets (Parent = the PRD). Only the PRD links to the planning ticket; the sub-tickets hang off the PRD. | ||
| - Three phases, each its own PR on a branch reused off develop: (1) PRD file, PR under the planning ticket; (2) implementation tickets drafted as local files, PR under the PRD; (3) delete the temporary files, PR under the PRD. | ||
| - Planning files (prd.md plus one kebab-named file per proposed ticket) in docs/prd/<ticket>/ are temporary — they exist for PR review and are deleted in phase 3, once the PRD issue and child issues exist. ADRs (docs/adr/) and CONTEXT.md edits are real docs and persist. | ||
| - to-prd gains a pipeline mode: stage the PRD as docs/prd/<ticket>/prd.md for review. to-issues drafts the sub-tickets as local files in the same folder with Parent = the PRD. Standalone mode still publishes straight to the tracker. | ||
| - Issue creation is a manual skill step at each phase (to-prd publishes the PRD issue, to-issues the children). No merge automation, and the planning ticket is not reopened — phase 1 runs under the planning ticket, phases 2 and 3 under the PRD. | ||
| - The ai-workflow label is created via gh label create and documented in docs/agents/issue-tracker.md. | ||
|
|
||
| See docs/agents/planning-pipeline.md for the operative stages and conventions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Planning pipeline | ||
|
|
||
| The default way to plan a feature: grill on a branch, review the plan, then create the tickets — as reviewable git history and GitHub issues, not an ephemeral chat session. Decision and rationale: ADR 0003. | ||
|
|
||
| ## When to use it | ||
|
|
||
| Most of the time — any grill-with-docs or to-prd session for planning a feature. Skip only for trivial changes that need no planning session. | ||
|
|
||
| ## Hierarchy | ||
|
|
||
| - **Planning ticket** — the idea/question. Entry point; names the branch. | ||
| - **PRD** — the plan, published as an issue that links up to the planning ticket. Parent of the implementation tickets. | ||
| - **Implementation tickets** — tracer-bullet slices; each has Parent = the PRD, not the planning ticket. | ||
|
|
||
| Only the PRD links to the planning ticket; everything else hangs off the PRD. | ||
|
|
||
| ## Phases | ||
|
|
||
| Each phase is its own PR against develop, on a branch reused per phase (recreate {issue}-{kebab-title} off develop after each merge). "Under X" means the PR references issue X. | ||
|
|
||
| 1. **PRD — PR under the planning ticket.** Run grill-with-docs (CONTEXT.md + ADR edits) and to-prd (PRD saved to docs/prd/<ticket>/prd.md). Review the plan in the draft PR. Once it's approved and merged, publish the PRD as an issue (to-prd) linked to the planning ticket. | ||
|
|
||
| 2. **Issues — PR under the PRD.** Draft the implementation tickets as local files in docs/prd/<ticket>/ — one kebab-named file per proposed ticket — with to-issues. Review them in the draft PR. Once merged, create the child issues (to-issues) with Parent = the PRD. | ||
|
|
||
| 3. **Cleanup — PR under the PRD.** Delete the temporary planning files (PRD + issue drafts); the PRD issue and its child issues are now the durable home. | ||
|
|
||
| Creating the issues is a manual skill step at each phase (to-prd for the PRD issue, to-issues for the children) — there is no merge automation, and the planning ticket is not reopened. | ||
|
|
||
| ## Where artifacts live | ||
|
|
||
| | Artifact | Location | Lifetime | | ||
| | --- | --- | --- | | ||
| | PRD + ticket drafts | docs/prd/<ticket>/ (prd.md + one file per proposed ticket) | temporary (deleted in phase 3) | | ||
| | ADRs | docs/adr/ (see domain.md for the naming convention) | persist | | ||
| | Glossary updates | CONTEXT.md (root) | persist | | ||
|
|
||
| <ticket> is the planning ticket's number and kebab-title (the same string as the branch name), e.g. docs/prd/668-build-planning-pipeline/. | ||
|
|
||
| The planning files are temporary — they exist so the plan and the drafted tickets are reviewable in the diff, and are deleted in phase 3 once the PRD issue and child issues exist on the tracker. The ADRs and CONTEXT.md edits are real docs and persist. | ||
|
|
||
| ## Conventions | ||
|
|
||
| - **Branch:** {issue}-{kebab-title}, recreated off develop for each phase — no separate namespace. | ||
| - **PR:** draft, against develop, per the repo PR convention. | ||
| - **ai-workflow label:** marks tickets whose subject is the AI dev workflow itself, distinct from the product area labels. See issue-tracker.md for the palette. | ||
|
|
||
| See glossary.md for planning ticket, planning pipeline, PRD, and the triage roles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Planning artifacts (temporary) | ||
|
|
||
| One folder per PRD, named for it (`<issue>-<kebab-title>`, the same slug as the planning ticket and branch). It temporarily holds the PRD plus the drafted implementation tickets — one kebab-named file per proposed ticket — so they're reviewable in a draft PR. Once the PRD is published as an issue and its child tickets are created, the folder is deleted (phase 3) — their durable home is the tracker, not docs. | ||
|
|
||
| ``` | ||
| docs/prd/ | ||
| └── <issue>-<kebab-title>/ # named for the PRD; created during a planning session, deleted in phase 3 | ||
| ├── prd.md | ||
| └── <ticket-proposed-kebab>.md # one file per proposed implementation ticket (phase 2) | ||
| ``` | ||
|
|
||
| ADRs do not live here — they go in docs/adr/. Glossary updates go in the root CONTEXT.md. See docs/agents/planning-pipeline.md for the full flow and ADR 0003 for the decision. | ||
|
|
||
| prd.md follows the template in the to-prd skill (.claude/skills/to-prd/SKILL.md); each proposed-ticket file follows the issue template in the to-issues skill. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 3 still says PRDs live as GitHub issues, contradicts the planning-pipeline default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved — we went back and forth on this one. Landing point: PRDs do live as GitHub issues — a PRD issue that parents the implementation tickets (it stays a PRD, not relabeled to an epic). docs/prd// is only temporary staging so the PRD is reviewable in the diff before it's published, then deleted. Line 3 now says that, so the contradiction's gone.
Generated by Claude Code