Optimize CI workflows: combine lint/prettier, add path filters#552
Draft
Optimize CI workflows: combine lint/prettier, add path filters#552
Conversation
- Combine lint-check.yml and prettier-check.yml into a single client-ci.yml that runs both checks in one job (single npm install), with path filter on angular-client/ so it only triggers on client changes - Add scylla-server/ path filter to scylla-ci.yml so it skips on unrelated changes - Add path filters to build-check.yml (angular-client/, scylla-server/, compose/) to skip Docker Compose builds on unrelated changes - Standardize Node.js version to 20.17.0 (was 18.17.1 for prettier) - Use npm ci instead of npm install for faster, deterministic installs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…os into 229-optimize-workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Combined the separate lint-check and prettier-check workflows into a single client-ci.yml that shares one checkout/setup/install step. Added path filters to all workflows so they only trigger when relevant source directories change. Switched from Docker Compose v1 to v2 (pre-installed on GH Actions runners), swapped npm install for
npm ci, and fixed the --max-warnings=0 flag passthrough to ng lint by adding a -- separator. Also bumped Node from 18.17.1 to 20.17.0 in the client workflow.Test Cases
Checklist
package-lock.jsonchanges (unless dependencies have changed)Closes #229