python3Packages.soundfile: 0.12.1 -> 0.13.1#371712
Closed
matthiasdotsh wants to merge 1 commit intoNixOS:masterfrom
Closed
python3Packages.soundfile: 0.12.1 -> 0.13.1#371712matthiasdotsh wants to merge 1 commit intoNixOS:masterfrom
matthiasdotsh wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
Bot
added
6.topic: python
Contributor
|
Contributor
Author
|
Is there a way to determine the reasons for the package failures? Currently, I see three possible explanations:
|
Contributor
|
Tests of Hydra builds fine https://hydra.nixos.org/job/nixpkgs/trunk/python312Packages.librosa.x86_64-linux |
Contributor
Author
|
I took a closer look and it seems that this is an upstream issue with I forked librosa and ran the tests in CI. With soundfile==0.12.1, everything works fine, but with soundfile==0.13.0, I experience the same errors as in the Hydra build. |
|
This may be related to a bugfix in soundfile, which was merged in v0.13.0: bastibe/python-soundfile#446 |
Contributor
Author
|
Looks like this was a regression in soundcard that has been fixed in 0.13.1. I will update and rebase this MR. |
matthiasdotsh
force-pushed
the
update-python-soundcard-0.13.0
branch
from
1a797ec to
e82e9ae
Compare
matthiasdotsh
changed the title
matthiasdotsh
force-pushed
the
update-python-soundcard-0.13.0
branch
from
e82e9ae to
1d9a743
Compare
Contributor
|
Contributor
|
Contributor
Author
|
Just to make sure I understood it correctly: nixpkgs-review checks which packages are affected by my changes, then takes the current master, applies my changes, and tries to rebuild the packages, right? I just tried to rebuild error: builder for '/nix/store/43mav7fc2zn81zwl95g1dzrws9kqic35-python3.12-private-gpt-0.6.2.drv' failed with exit code 1;
last 25 log lines:
> Running phase: unpackPhase
> unpacking source archive /nix/store/59fkdhg9dg3pfim3zqy1r37zjl0wwczr-source
> source root is source
> setting SOURCE_DATE_EPOCH to timestamp 315619200 of file "source/version.txt"
> Running phase: patchPhase
> Running phase: updateAutotoolsGnuConfigScriptsPhase
> Running phase: configurePhase
> no configure script, doing nothing
> Running phase: buildPhase
> Executing pypaBuildPhase
> Creating a wheel...
> pypa build flags: --no-isolation --outdir dist/ --wheel
> * Getting build dependencies for wheel...
> * Building wheel...
> Successfully built private_gpt-0.6.2-py3-none-any.whl
> Finished creating a wheel...
> /build/source/dist /build/source
> Unpacking to: unpacked/private_gpt-0.6.2...OK
> Repacking wheel as ./private_gpt-0.6.2-py3-none-any.whl...OK
> /build/source
> Finished executing pypaBuildPhase
> Running phase: pythonRuntimeDepsCheckHook
> Executing pythonRuntimeDepsCheck
> Checking runtime dependencies for private_gpt-0.6.2-py3-none-any.whl
> - watchdog<5.0.0,>=4.0.1 not satisfied by version 6.0.0
For full logs, run 'nix log /nix/store/43mav7fc2zn81zwl95g1dzrws9kqic35-python3.12-private-gpt-0.6.2.drv'.To me, this doesn't look like an error caused by a newer version of soundfile. Am I missing something, or is it possible that the packages on the current master also fail to build independently of my changes? |
Contributor
|
The |
azuwis
approved these changes
Feb 3, 2025
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2241 |
Contributor
Author
|
Soundfile has been updated to 0.13.0 in the meantime, see 64abea1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.