Remove regex from S3BinaryCacheStore#14930
Open
Zaczero wants to merge 1 commit intoNixOS:masterfrom
Open
Conversation
github-actions
Bot
added
the
store
Member
|
Hm, what's the motivation for this? The new code seems harder to read than the regex. |
Member
Author
|
Performance and regex eradication |
Member
|
@Zaczero you should find us on Matrix #nix-dev:nixos.org. We see that you want to contribute a lot, which is good. We should talk a bit about prioritizes/objectives, so there will be less per-PR questioning whether we want the change in question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.