nix-utils: remove FfiRealisation wrapper, return Realisation directly from query#1581
Open
amaanq wants to merge 1 commit intoNixOS:masterfrom
Open
nix-utils: remove FfiRealisation wrapper, return Realisation directly from query#1581amaanq wants to merge 1 commit intoNixOS:masterfrom
FfiRealisation wrapper, return Realisation directly from query#1581amaanq wants to merge 1 commit intoNixOS:masterfrom
Conversation
Member
|
I don't think |
amaanq
force-pushed
the
harmonia-daemon-store
branch
2 times, most recently
from
62bfa3c to
c91f5dc
Compare
amaanq
force-pushed
the
harmonia-daemon-store
branch
3 times, most recently
from
aa4334e to
b547264
Compare
amaanq
changed the title
BaseStore traitFfiRealisation wrapper, return Realisation directly from query
amaanq
force-pushed
the
harmonia-daemon-store
branch
from
b547264 to
16c16a9
Compare
…ctly from query Callers went through `FfiRealisation.as_rust()` to deserialize the JSON into a `Realisation` every time. Inlining that into the trait method removes the wrapper struct, the unsafe Send/Sync impls, and the extra conversion step at each call site.
amaanq
force-pushed
the
harmonia-daemon-store
branch
from
16c16a9 to
1cfc034
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers went through
FfiRealisation.as_rust()to deserialize the JSONinto a
Realisationevery time. Inlining that into the trait methodremoves the wrapper struct, the unsafe Send/Sync impls, and the extra
conversion step at each call site.