Finish RLS SQL Server guard and migration CLI docs#56
Open
MelbourneDeveloper wants to merge 1 commit intomainfrom
Open
Finish RLS SQL Server guard and migration CLI docs#56MelbourneDeveloper wants to merge 1 commit intomainfrom
MelbourneDeveloper wants to merge 1 commit intomainfrom
Conversation
Add the SQL Server RLS unsupported CLI guard and regression test. Mark the RLS plan complete and consolidate the migration CLI spec into the migration spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Adds a fail-closed SQL Server RLS guard to
DataProviderMigrateand consolidates the migration CLI contract into the main migration spec.What Was Added?
DataProviderMigrateRlsUnsupportedTestscovering SQL Server RLS migration attempts.[MIG-CLI]sections todocs/specs/migration-spec.mdfor commands, YAML-only input, schema export workflow, migrations assembly rules, build integration, build order, and forbidden CLI patterns.What Was Changed or Deleted?
DataProviderMigratenow detectssqlserver/mssqlproviders withrowLevelSecurityYAML and exits withMIG-E-RLS-MSSQL-UNSUPPORTEDbefore falling through to generic provider handling.docs/specs/migration-cli-spec.mdafter moving its contract intodocs/specs/migration-spec.md.DataProviderMigratecommand shape.How Do The Automated Tests Prove It Works?
DataProviderMigrateRlsUnsupportedTests.Migrate_SqlServerProviderWithRlsSchema_ReturnsCanonicalUnsupportedErrorproves SQL Server RLS YAML returns exit code 1 withMIG-E-RLS-MSSQL-UNSUPPORTEDand the missing package detail.dotnet test Migration/Nimblesite.DataProvider.Migration.Tests/Nimblesite.DataProvider.Migration.Tests.csproj --filter "FullyQualifiedName~Rls|FullyQualifiedName~RLS"-> 159 passed.make cipassed after installing the local Playwright Chromium runtime required by Reporting integration tests.PostgresRlsE2ETestsandPostgresRlsNapShapeTests, with migration coverage above threshold.Spec / Doc Changes
docs/specs/migration-spec.mdunder[MIG-CLI]IDs.DataProviderMigrateand the consolidated migration spec.docs/plans/RLS-PLAN.md.Breaking Changes