Replace previous testId suffix#91
Open
cmcculloh-kr wants to merge 3 commits intoNimaSoroush:masterfrom
Open
Conversation
Instead of continually appending new suffixes, replace the previous testId suffix with a new one. Uses a `.` instead of a space so that we aren't introducing spaces into filenames where the user may not want them.
Owner
|
Hi @CormacMcCarthy, |
NimaSoroush
reviewed
Jun 28, 2018
| .waitFor(1000) | ||
| .screenshot() | ||
| .toMatchSnapshot() | ||
| .toMatchSnapshot((resultDetail) => { |
Owner
There was a problem hiding this comment.
Probably better to write a new test instead of updating the existing one. These tests are good examples for differencify usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of continually appending new suffixes, replace the previous testId suffix with a new one.
Uses a
.instead of a space so that we aren't introducing spaces into filenames where the user may not want them.