Feature/remove post fix#172
Open
Stanimir-Georgiev wants to merge 4 commits intoNimaSoroush:masterfrom
Open
Conversation
NimaSoroush
requested changes
Apr 18, 2020
| this.configuration = sanitiseGlobalConfiguration(conf); | ||
| this.browser = null; | ||
| this.testId = 0; | ||
| conf.removePostFix === true ? this.testId = undefined : this.testId = 0 |
Owner
There was a problem hiding this comment.
Although you don't need this logic here at all.
|
|
||
| init(config) { | ||
| this.testId += 1; | ||
| if (this.testId !== undefined) { |
Owner
There was a problem hiding this comment.
I would rather do this here
this.testId = this.configuration ? undefined : this.testId + 1;
| configuration.testId = testId; | ||
| if (testId !== undefined) { | ||
| configuration.testId = testId; | ||
| } |
Owner
There was a problem hiding this comment.
also add
configuration.removePostFix = checkProperty(conf, 'removePostFix', 'boolean')
? conf.removePostFix
: globalConfig.saveCurrentImage;
To sanitiseGlobalConfiguration function.
and
removePostFix: false,
to defaultConfigs.js
Owner
|
Hi @Stanimir-Georgiev, thanks for your contribution. I added couple of comments. Would you please also write some unit tests too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#157
Allows passing config object property, that removes the index posfix