Skip to content

Fix access list and certificate table sorting#5629

Open
puneetdixit200 wants to merge 1 commit into
NginxProxyManager:developfrom
puneetdixit200:fix-access-cert-table-sorting
Open

Fix access list and certificate table sorting#5629
puneetdixit200 wants to merge 1 commit into
NginxProxyManager:developfrom
puneetdixit200:fix-access-cert-table-sorting

Conversation

@puneetdixit200
Copy link
Copy Markdown

Fixes #5609.

Summary

  • Enable the sorted row model for Access Lists and Certificates tables so clickable headers actually reorder rows.
  • Add explicit sort functions for object and count-based columns, with ascending as the first sort direction.
  • Add the missing streams certificate expansion type and regression tests for name-column sorting.

Tests

  • yarn test --run src/pages/Access/Table.test.tsx src/pages/Certificates/Table.test.tsx
  • yarn lint
  • git diff --check
  • yarn build

AI assistance was used to prepare this change; I reviewed and tested it.

@nginxproxymanagerci
Copy link
Copy Markdown

Docker Image for build 1 is available on DockerHub:

nginxproxymanager/nginx-proxy-manager-dev:pr-5629

Note

Ensure you backup your NPM instance before testing this image! Especially if there are database changes.
This is a different docker image namespace than the official image.

Warning

Changes and additions to DNS Providers require verification by at least 2 members of the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sorting Access Lists and Certificates is broken

1 participant